Peer Data Channels

Review Request #3 — Created Oct. 4, 2018 and submitted

sarah
cwtch
peerdata
8ab4752...
dan
Merge branch 'export-fix' of cwtch.im/cwtch into master


Shortcut for Primary Identity


Adding Cwtch Peer Data Channel


  • 4
  • 0
  • 0
  • 0
  • 4
Description From Last Updated
This Review includes the seperate and still under discussion Primary Identity. The Peer Data Channel looks good, I approve that dan dan
"alice" dan dan
dataHandler func(string, []byte) []byte dan dan
I don't love that we changed the defaultand used use case to now always require a 'nil' for the purpose ... dan dan
dan
  1. 
      
  2. app/peer/alice/alice.go (Diff revision 1)
     
     

    "alice"

  3. peer/cwtch_peer.go (Diff revision 1)
     
     

    dataHandler func(string, []byte) []byte

  4. peer/cwtch_peer.go (Diff revision 1)
     
     

    I don't love that we changed the defaultand used use case to now always require a 'nil' for the purpose of supporting debuging and rapid prototyping. it will never be default in apps to use this.

    What about

    CwtchPeer.SetDataHandler with a backing struct field, default nil
    Then in the test/prototype cases you just call SetDataHandler on the peer before Listen
    Listen then only sets it if its not nil

  5. 
      
sarah
dan
  1. Ship It!
  2. This Review includes the seperate and still under discussion Primary Identity.

    The Peer Data Channel looks good, I approve that

  3. 
      
sarah
Review request changed

Status: Closed (submitted)

Loading...