v3 onions

Review Request #2 — Created Oct. 4, 2018 and submitted

sarah
libricochet-go
v3onions
c1ab417...
dan
v3 onions


  • 0
  • 0
  • 2
  • 4
  • 6
Description From Last Updated
dan
  1. 
      
  2. Looks good! just a few minor nits and comments!

  3. application/application.go (Diff revision 1)
     
     

    InitV2 ?
    Deprecation warning?

  4. application/examples/v3/main.go (Diff revision 1)
     
     
     

    do we / can we compare and fatal if not matched?

  5. application/ricochetonion.go (Diff revision 1)
     
     

    I'm wondering if we want to publish like a bulb adendum micro lib with v3 stuff, or just fork it?

  6. identity/identity.go (Diff revision 1)
     
     
     

    InitV3 with corresponding utils.LoadV3PrivateKeyFromFile

    needed? nice to have? (ie do or create an issue in gogs for later?)

  7. identity/identity.go (Diff revision 1)
     
     
     
     
     
     
     
     

    is there another option? couldnt it be

    if i.edpk != nil {
    pub := i.edpk.Public().(ed25519.PublicKey)
    return utils.GetTorV3Hostname(
    pub)
    } else {
    return utils.GetTorHostname(i.PublicKeyBytes())
    }

    ?

  8. 
      
sarah
sarah
Review request changed

Status: Closed (submitted)

Loading...