Change Summary:
- Changed app's storage of peers to be by onion instead of name
- updated app/cli list-profiles and select-profiles accordingly
Branch: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+746 -300) |
Review Request #1 — Created Aug. 20, 2018 and discarded
Information | |
---|---|
dan | |
cwtch | |
master | |
Reviewers | |
sarah |
Add deniable profile storage:
Add multiple peer support to app and app/cli:
- app now supports multiple peers
- app/cli upgraded to require user to select an active peer for commands
- TODO: fast follow to allow them to do the same for a group and alter group commands to use that instead of argument
Description | From | Last Updated |
---|---|---|
Can we add some comments in here regarding which features are not yet in use? Looks like right now the ... |
|
|
This makeup doesn't make much sense to me. I can easily imagine someone maintaining 2 public identities (personal / work),but ... |
|
|
let's use defer unlock() everywhere...it's a much better patten |
|
|
deadlock |
|
Branch: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+746 -300) |
storage/profile_store.go (Diff revision 2) |
---|
we should come up with a strategy for handling critical failures like this
Addresed comments:
- added defers for most unlocks, fixed one deadlock, improved error handling
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+759 -298) |
app/app.go (Diff revision 3) |
---|
Can we add some comments in here regarding which features are not yet in use?
Looks like right now the app only ever triggeres GroupMaster?
storage/profile_store.go (Diff revision 3) |
---|
This makeup doesn't make much sense to me. I can easily imagine someone maintaining 2 public identities (personal / work),but probably at most maintaining 1 secret profile.
We should probably chat about this next meeting.
storage/profile_store.go (Diff revision 3) |
---|
let's use defer unlock() everywhere...it's a much better patten